Add yoga to app search paths #47195
Closed
Add yoga to app search paths #47195
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipolleschi
force-pushed
the
export-D64925222
branch
from
f895581 to
4e0444b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64925222 |
facebook-github-bot
added
CLA Signed
Summary: Pull Request resolved: facebook#47195 When a user wants to create a Fabric Component i their app (not in a separate library) the app fails to build because: - The custom component has to inherit from `RCTViewComponentView` - `RCTViewComponentView` imports `ViewProps.h` - `ViewProps.h` imports `HostPlatformViewProps.h` - `HostPlatformViewProps.h` imports `BaseViewProps.h` - `BaseViewProps.h` imports `YogaStylableProps.h` which is a Yoga private header and the App has not visibility over it. It is also not possible to fix this issue with forward declaring the `YogaStylableProps`, because `BaseViewProps` inherit from the yoga's props, so the compiler needs the full declaration of `YogaStylableProps` to work This needs to be picked in 0.76 ## Changelog [iOS][Fixed] - Give apps access to Yoga headers Differential Revision: D64925222
|
This pull request was exported from Phabricator. Differential Revision: D64925222 |
cipolleschi
force-pushed
the
export-D64925222
branch
from
4e0444b to
6fe3e79
Compare
|
This pull request has been merged in e851e73. |
|
This pull request was successfully merged by @cipolleschi in e851e73 When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Nov 12, 2024
Summary: Pull Request resolved: #47195 When a user wants to create a Fabric Component i their app (not in a separate library) the app fails to build because: - The custom component has to inherit from `RCTViewComponentView` - `RCTViewComponentView` imports `ViewProps.h` - `ViewProps.h` imports `HostPlatformViewProps.h` - `HostPlatformViewProps.h` imports `BaseViewProps.h` - `BaseViewProps.h` imports `YogaStylableProps.h` which is a Yoga private header and the App has not visibility over it. It is also not possible to fix this issue with forward declaring the `YogaStylableProps`, because `BaseViewProps` inherit from the yoga's props, so the compiler needs the full declaration of `YogaStylableProps` to work This needs to be picked in 0.76 ## Changelog [iOS][Fixed] - Give apps access to Yoga headers Reviewed By: blakef Differential Revision: D64925222 fbshipit-source-id: e724076bbfb0a678948340dfab2ce609e6509533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When a user wants to create a Fabric Component i their app (not in a separate library) the app fails to build because:
RCTViewComponentViewRCTViewComponentViewimportsViewProps.hViewProps.himportsHostPlatformViewProps.hHostPlatformViewProps.himportsBaseViewProps.hBaseViewProps.himportsYogaStylableProps.hwhich is a Yoga private header and the App has not visibility over it.
It is also not possible to fix this issue with forward declaring the
YogaStylableProps, becauseBaseViewPropsinherit from the yoga's props, so the compiler needs the full declaration ofYogaStylablePropsto workThis needs to be picked in 0.76
Changelog
[iOS][Fixed] - Give apps access to Yoga headers
Differential Revision: D64925222